Home
last modified time | relevance | path

Searched hist:ff6ed7141d87d26eafa2b8e4df969623e40fac49 (Results 1 – 1 of 1) sorted by relevance

/openbmc/qemu/
H A Dblock.cdiff ff6ed7141d87d26eafa2b8e4df969623e40fac49 Thu Apr 27 16:58:18 CDT 2017 Eric Blake <eblake@redhat.com> block: Simplify bdrv_append_temp_snapshot() logic

Noticed while checking Coccinelle results. Naming a label 'out:'
when it is only used on error paths is weird. Also, we had some
dead stores to 'ret'. Meanwhile we know that snapshot_options
is NULL on success and that QDECREF(NULL) is safe. So merge the
two exit paths into one by careful control over bs_snapshot.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20170427215821.19397-8-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>