Home
last modified time | relevance | path

Searched hist:fd0977d0f42d3e73121b88f57c7d48ca9b861a58 (Results 1 – 3 of 3) sorted by relevance

/openbmc/linux/sound/pci/asihpi/
H A Dhpicmn.cdiff fd0977d0f42d3e73121b88f57c7d48ca9b861a58 Fri Oct 29 14:35:25 CDT 2010 Jesper Juhl <jj@chaosbits.net> ALSA: asihpi - Unsafe memory management when allocating control cache

I noticed that sound/pci/asihpi/hpicmn.c::hpi_alloc_control_cache() does
not check the return value from kmalloc(), which may fail.
If kmalloc() fails we'll dereference a null pointer and things will go bad
fast.
There are two memory allocations in that function and there's also the
problem that the first may succeed and the second may fail and nothing is
done about that either which will also go wrong down the line.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Eliot Blennerhassett <linux@audioscience.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
H A Dhpi6000.cdiff fd0977d0f42d3e73121b88f57c7d48ca9b861a58 Fri Oct 29 14:35:25 CDT 2010 Jesper Juhl <jj@chaosbits.net> ALSA: asihpi - Unsafe memory management when allocating control cache

I noticed that sound/pci/asihpi/hpicmn.c::hpi_alloc_control_cache() does
not check the return value from kmalloc(), which may fail.
If kmalloc() fails we'll dereference a null pointer and things will go bad
fast.
There are two memory allocations in that function and there's also the
problem that the first may succeed and the second may fail and nothing is
done about that either which will also go wrong down the line.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Eliot Blennerhassett <linux@audioscience.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
H A Dhpi6205.cdiff fd0977d0f42d3e73121b88f57c7d48ca9b861a58 Fri Oct 29 14:35:25 CDT 2010 Jesper Juhl <jj@chaosbits.net> ALSA: asihpi - Unsafe memory management when allocating control cache

I noticed that sound/pci/asihpi/hpicmn.c::hpi_alloc_control_cache() does
not check the return value from kmalloc(), which may fail.
If kmalloc() fails we'll dereference a null pointer and things will go bad
fast.
There are two memory allocations in that function and there's also the
problem that the first may succeed and the second may fail and nothing is
done about that either which will also go wrong down the line.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Eliot Blennerhassett <linux@audioscience.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>