Searched hist:fc6a6521556c8250e356ddc6a3f2391aa62dc976 (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/net/wireless/ath/ath6kl/ |
| H A D | wmi.c | diff efba106f89fc6848726716c101f4c84e88720a9c Mon May 03 06:57:09 CDT 2021 Greg Kroah-Hartman <gregkh@linuxfoundation.org> Revert "ath6kl: return error code in ath6kl_wmi_set_roam_lrssi_cmd()"
This reverts commit fc6a6521556c8250e356ddc6a3f2391aa62dc976.
Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.
Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted. It will be fixed up "correctly" in a
later kernel change.
The change being reverted does NOTHING as the caller to this function
does not even look at the return value of the call. So the "claim" that
this fixed an an issue is not true. It will be fixed up properly in a
future patch by propagating the error up the stack correctly.
Cc: Kangjie Lu <kjlu@umn.edu>
Cc: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-43-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff fc6a6521556c8250e356ddc6a3f2391aa62dc976 Wed Dec 26 00:43:28 CST 2018 Kangjie Lu <kjlu@umn.edu> ath6kl: return error code in ath6kl_wmi_set_roam_lrssi_cmd()
ath6kl_wmi_cmd_send could fail, so let's return its error code upstream.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
|