Home
last modified time | relevance | path

Searched hist:f51d23c80af73c95e0ce703ad06a300f1b3d63ef (Results 1 – 4 of 4) sorted by relevance

/openbmc/qemu/block/export/
H A Dexport.cdiff 8573823f3ba2b63926f82d5732473e0cd73c1213 Thu Jun 24 03:38:24 CDT 2021 Max Reitz <mreitz@redhat.com> block/export: Conditionally ignore set-context error

When invoking block-export-add with some iothread and
fixed-iothread=false, and changing the node's iothread fails, the error
is supposed to be ignored.

However, it is still stored in *errp, which is wrong. If a second error
occurs, the "*errp must be NULL" assertion in error_setv() fails:

qemu-system-x86_64: ../util/error.c:59: error_setv: Assertion
`*errp == NULL' failed.

So if fixed-iothread=false, we should ignore the error by passing NULL
to bdrv_try_set_aio_context().

Fixes: f51d23c80af73c95e0ce703ad06a300f1b3d63ef
("block/export: add iothread and fixed-iothread options")
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210624083825.29224-2-mreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
diff f51d23c80af73c95e0ce703ad06a300f1b3d63ef Tue Sep 29 07:55:16 CDT 2020 Stefan Hajnoczi <stefanha@redhat.com> block/export: add iothread and fixed-iothread options

Make it possible to specify the iothread where the export will run. By
default the block node can be moved to other AioContexts later and the
export will follow. The fixed-iothread option forces strict behavior
that prevents changing AioContext while the export is active. See the
QAPI docs for details.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20200929125516.186715-5-stefanha@redhat.com
[Fix stray '#' character in block-export.json and add missing "(since:
5.2)" as suggested by Eric Blake.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
H A Dvhost-user-blk-server.cdiff f51d23c80af73c95e0ce703ad06a300f1b3d63ef Tue Sep 29 07:55:16 CDT 2020 Stefan Hajnoczi <stefanha@redhat.com> block/export: add iothread and fixed-iothread options

Make it possible to specify the iothread where the export will run. By
default the block node can be moved to other AioContexts later and the
export will follow. The fixed-iothread option forces strict behavior
that prevents changing AioContext while the export is active. See the
QAPI docs for details.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20200929125516.186715-5-stefanha@redhat.com
[Fix stray '#' character in block-export.json and add missing "(since:
5.2)" as suggested by Eric Blake.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
/openbmc/qemu/qapi/
H A Dblock-export.jsondiff f51d23c80af73c95e0ce703ad06a300f1b3d63ef Tue Sep 29 07:55:16 CDT 2020 Stefan Hajnoczi <stefanha@redhat.com> block/export: add iothread and fixed-iothread options

Make it possible to specify the iothread where the export will run. By
default the block node can be moved to other AioContexts later and the
export will follow. The fixed-iothread option forces strict behavior
that prevents changing AioContext while the export is active. See the
QAPI docs for details.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20200929125516.186715-5-stefanha@redhat.com
[Fix stray '#' character in block-export.json and add missing "(since:
5.2)" as suggested by Eric Blake.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
/openbmc/qemu/nbd/
H A Dserver.cdiff f51d23c80af73c95e0ce703ad06a300f1b3d63ef Tue Sep 29 07:55:16 CDT 2020 Stefan Hajnoczi <stefanha@redhat.com> block/export: add iothread and fixed-iothread options

Make it possible to specify the iothread where the export will run. By
default the block node can be moved to other AioContexts later and the
export will follow. The fixed-iothread option forces strict behavior
that prevents changing AioContext while the export is active. See the
QAPI docs for details.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20200929125516.186715-5-stefanha@redhat.com
[Fix stray '#' character in block-export.json and add missing "(since:
5.2)" as suggested by Eric Blake.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>