Searched hist:e55eb806dbb97f53794b0c2f86983d34f6696845 (Results 1 – 5 of 5) sorted by relevance
/openbmc/qemu/qga/vss-win32/ |
H A D | requester.h | diff e55eb806dbb97f53794b0c2f86983d34f6696845 Wed Feb 24 18:14:52 CST 2016 Michael Roth <mdroth@linux.vnet.ibm.com> qga: fix w32 breakage due to missing osdep.h includes
requester.h relied on qemu/compiler.h definitions to handle GCC_FMT_ATTR() stub, but this include was removed as part of scripted clean-ups via 30456d5:
all: Clean up includes
under the assumption that all C files would have included it via qemu/osdep.h at that point. requester.cpp was likely missed due to C++ files requiring manual/special handling as well as VSS build options needing to be enabled to trigger build failures.
Fix this by including qemu/osdep.h. That in turn pulls in a macro from qapi/error.h that conflicts with a struct field name in requester.h, so fix that as well by renaming the field.
While we're at it, fix up provider.cpp/install.cpp to include osdep.h as well.
Cc: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> Reviewed-by: Eric Blake <eblake@redhat.com>
|
H A D | provider.cpp | diff e55eb806dbb97f53794b0c2f86983d34f6696845 Wed Feb 24 18:14:52 CST 2016 Michael Roth <mdroth@linux.vnet.ibm.com> qga: fix w32 breakage due to missing osdep.h includes
requester.h relied on qemu/compiler.h definitions to handle GCC_FMT_ATTR() stub, but this include was removed as part of scripted clean-ups via 30456d5:
all: Clean up includes
under the assumption that all C files would have included it via qemu/osdep.h at that point. requester.cpp was likely missed due to C++ files requiring manual/special handling as well as VSS build options needing to be enabled to trigger build failures.
Fix this by including qemu/osdep.h. That in turn pulls in a macro from qapi/error.h that conflicts with a struct field name in requester.h, so fix that as well by renaming the field.
While we're at it, fix up provider.cpp/install.cpp to include osdep.h as well.
Cc: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> Reviewed-by: Eric Blake <eblake@redhat.com>
|
H A D | install.cpp | diff e55eb806dbb97f53794b0c2f86983d34f6696845 Wed Feb 24 18:14:52 CST 2016 Michael Roth <mdroth@linux.vnet.ibm.com> qga: fix w32 breakage due to missing osdep.h includes
requester.h relied on qemu/compiler.h definitions to handle GCC_FMT_ATTR() stub, but this include was removed as part of scripted clean-ups via 30456d5:
all: Clean up includes
under the assumption that all C files would have included it via qemu/osdep.h at that point. requester.cpp was likely missed due to C++ files requiring manual/special handling as well as VSS build options needing to be enabled to trigger build failures.
Fix this by including qemu/osdep.h. That in turn pulls in a macro from qapi/error.h that conflicts with a struct field name in requester.h, so fix that as well by renaming the field.
While we're at it, fix up provider.cpp/install.cpp to include osdep.h as well.
Cc: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> Reviewed-by: Eric Blake <eblake@redhat.com>
|
H A D | requester.cpp | diff e55eb806dbb97f53794b0c2f86983d34f6696845 Wed Feb 24 18:14:52 CST 2016 Michael Roth <mdroth@linux.vnet.ibm.com> qga: fix w32 breakage due to missing osdep.h includes
requester.h relied on qemu/compiler.h definitions to handle GCC_FMT_ATTR() stub, but this include was removed as part of scripted clean-ups via 30456d5:
all: Clean up includes
under the assumption that all C files would have included it via qemu/osdep.h at that point. requester.cpp was likely missed due to C++ files requiring manual/special handling as well as VSS build options needing to be enabled to trigger build failures.
Fix this by including qemu/osdep.h. That in turn pulls in a macro from qapi/error.h that conflicts with a struct field name in requester.h, so fix that as well by renaming the field.
While we're at it, fix up provider.cpp/install.cpp to include osdep.h as well.
Cc: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> Reviewed-by: Eric Blake <eblake@redhat.com>
|
/openbmc/qemu/qga/ |
H A D | vss-win32.c | diff e55eb806dbb97f53794b0c2f86983d34f6696845 Wed Feb 24 18:14:52 CST 2016 Michael Roth <mdroth@linux.vnet.ibm.com> qga: fix w32 breakage due to missing osdep.h includes
requester.h relied on qemu/compiler.h definitions to handle GCC_FMT_ATTR() stub, but this include was removed as part of scripted clean-ups via 30456d5:
all: Clean up includes
under the assumption that all C files would have included it via qemu/osdep.h at that point. requester.cpp was likely missed due to C++ files requiring manual/special handling as well as VSS build options needing to be enabled to trigger build failures.
Fix this by including qemu/osdep.h. That in turn pulls in a macro from qapi/error.h that conflicts with a struct field name in requester.h, so fix that as well by renaming the field.
While we're at it, fix up provider.cpp/install.cpp to include osdep.h as well.
Cc: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> Reviewed-by: Eric Blake <eblake@redhat.com>
|