Searched hist:d9dc1702b297ec4a6bb9c0326a70641b322ba886 (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/md/bcache/ |
| H A D | super.c | diff d9dc1702b297ec4a6bb9c0326a70641b322ba886 Fri Jun 17 17:01:54 CDT 2016 Eric Wheeler <git@linux.ewheeler.net> bcache: register_bcache(): call blkdev_put() when cache_alloc() fails
register_cache() is supposed to return an error string on error so that
register_bcache() will will blkdev_put and cleanup other user counters,
but it does not set 'char *err' when cache_alloc() fails (eg, due to
memory pressure) and thus register_bcache() performs no cleanup.
register_bcache() <----------\ <- no jump to err_close, no blkdev_put()
| |
+->register_cache() | <- fails to set char *err
| |
+->cache_alloc() ---/ <- returns error
This patch sets `char *err` for this failure case so that register_cache()
will cause register_bcache() to correctly jump to err_close and do
cleanup. This was tested under OOM conditions that triggered the bug.
Signed-off-by: Eric Wheeler <bcache@linux.ewheeler.net>
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Cc: stable@vger.kernel.org
|