Searched hist:d2e381c4963663bca6f30c3b996fa4dbafe8fcb5 (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/net/core/ |
H A D | rtnetlink.c | diff d2e381c4963663bca6f30c3b996fa4dbafe8fcb5 Wed Jun 09 06:17:53 CDT 2021 Ido Schimmel <idosch@nvidia.com> rtnetlink: Fix regression in bridge VLAN configuration
Cited commit started returning errors when notification info is not filled by the bridge driver, resulting in the following regression:
# ip link add name br1 type bridge vlan_filtering 1 # bridge vlan add dev br1 vid 555 self pvid untagged RTNETLINK answers: Invalid argument
As long as the bridge driver does not fill notification info for the bridge device itself, an empty notification should not be considered as an error. This is explained in commit 59ccaaaa49b5 ("bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify").
Fix by removing the error and add a comment to avoid future bugs.
Fixes: a8db57c1d285 ("rtnetlink: Fix missing error code in rtnl_bridge_notify()") Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Nikolay Aleksandrov <nikolay@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|