Home
last modified time | relevance | path

Searched hist:d1da229ff1333d4619e55bb5d99ba2e7a280d984 (Results 1 – 1 of 1) sorted by relevance

/openbmc/qemu/target/i386/
H A Dops_sse.hdiff d1da229ff1333d4619e55bb5d99ba2e7a280d984 Sun Apr 24 17:01:23 CDT 2022 Paul Brook <paul@nowt.org> i386: pcmpestr 64-bit sign extension bug

The abs1 function in ops_sse.h only works sorrectly when the result fits
in a signed int. This is fine most of the time because we're only dealing
with byte sized values.

However pcmp_elen helper function uses abs1 to calculate the absolute value
of a cpu register. This incorrectly truncates to 32 bits, and will give
the wrong anser for the most negative value.

Fix by open coding the saturation check before taking the absolute value.

Signed-off-by: Paul Brook <paul@nowt.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>