/openbmc/linux/fs/nfsd/ |
H A D | xdr.h | diff cc028a10a48c3c555d7772d02f56eea9f86fdf79 Fri Oct 02 14:52:44 CDT 2020 Chuck Lever <chuck.lever@oracle.com> NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The trade-off was:
- No support for an NFSD proc function returning a non-success RPC accept_stat value. - No support for void NFS replies to non-NULL procedures. - Everyone pays for the deduplication with a few extra conditional branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding the NFS status code into the NFS XDR encoders themselves. Then update the NFS .pc_func methods to return an RPC accept_stat value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
H A D | nfsxdr.c | diff cc028a10a48c3c555d7772d02f56eea9f86fdf79 Fri Oct 02 14:52:44 CDT 2020 Chuck Lever <chuck.lever@oracle.com> NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The trade-off was:
- No support for an NFSD proc function returning a non-success RPC accept_stat value. - No support for void NFS replies to non-NULL procedures. - Everyone pays for the deduplication with a few extra conditional branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding the NFS status code into the NFS XDR encoders themselves. Then update the NFS .pc_func methods to return an RPC accept_stat value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
H A D | nfs3acl.c | diff cc028a10a48c3c555d7772d02f56eea9f86fdf79 Fri Oct 02 14:52:44 CDT 2020 Chuck Lever <chuck.lever@oracle.com> NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The trade-off was:
- No support for an NFSD proc function returning a non-success RPC accept_stat value. - No support for void NFS replies to non-NULL procedures. - Everyone pays for the deduplication with a few extra conditional branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding the NFS status code into the NFS XDR encoders themselves. Then update the NFS .pc_func methods to return an RPC accept_stat value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
H A D | nfs2acl.c | diff cc028a10a48c3c555d7772d02f56eea9f86fdf79 Fri Oct 02 14:52:44 CDT 2020 Chuck Lever <chuck.lever@oracle.com> NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The trade-off was:
- No support for an NFSD proc function returning a non-success RPC accept_stat value. - No support for void NFS replies to non-NULL procedures. - Everyone pays for the deduplication with a few extra conditional branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding the NFS status code into the NFS XDR encoders themselves. Then update the NFS .pc_func methods to return an RPC accept_stat value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
H A D | nfsproc.c | diff cc028a10a48c3c555d7772d02f56eea9f86fdf79 Fri Oct 02 14:52:44 CDT 2020 Chuck Lever <chuck.lever@oracle.com> NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The trade-off was:
- No support for an NFSD proc function returning a non-success RPC accept_stat value. - No support for void NFS replies to non-NULL procedures. - Everyone pays for the deduplication with a few extra conditional branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding the NFS status code into the NFS XDR encoders themselves. Then update the NFS .pc_func methods to return an RPC accept_stat value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
H A D | nfs3proc.c | diff cc028a10a48c3c555d7772d02f56eea9f86fdf79 Fri Oct 02 14:52:44 CDT 2020 Chuck Lever <chuck.lever@oracle.com> NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The trade-off was:
- No support for an NFSD proc function returning a non-success RPC accept_stat value. - No support for void NFS replies to non-NULL procedures. - Everyone pays for the deduplication with a few extra conditional branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding the NFS status code into the NFS XDR encoders themselves. Then update the NFS .pc_func methods to return an RPC accept_stat value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
H A D | nfs3xdr.c | diff cc028a10a48c3c555d7772d02f56eea9f86fdf79 Fri Oct 02 14:52:44 CDT 2020 Chuck Lever <chuck.lever@oracle.com> NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The trade-off was:
- No support for an NFSD proc function returning a non-success RPC accept_stat value. - No support for void NFS replies to non-NULL procedures. - Everyone pays for the deduplication with a few extra conditional branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding the NFS status code into the NFS XDR encoders themselves. Then update the NFS .pc_func methods to return an RPC accept_stat value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
H A D | nfssvc.c | diff cc028a10a48c3c555d7772d02f56eea9f86fdf79 Fri Oct 02 14:52:44 CDT 2020 Chuck Lever <chuck.lever@oracle.com> NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The trade-off was:
- No support for an NFSD proc function returning a non-success RPC accept_stat value. - No support for void NFS replies to non-NULL procedures. - Everyone pays for the deduplication with a few extra conditional branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding the NFS status code into the NFS XDR encoders themselves. Then update the NFS .pc_func methods to return an RPC accept_stat value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
H A D | nfs4proc.c | diff cc028a10a48c3c555d7772d02f56eea9f86fdf79 Fri Oct 02 14:52:44 CDT 2020 Chuck Lever <chuck.lever@oracle.com> NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The trade-off was:
- No support for an NFSD proc function returning a non-success RPC accept_stat value. - No support for void NFS replies to non-NULL procedures. - Everyone pays for the deduplication with a few extra conditional branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding the NFS status code into the NFS XDR encoders themselves. Then update the NFS .pc_func methods to return an RPC accept_stat value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
H A D | nfs4xdr.c | diff cc028a10a48c3c555d7772d02f56eea9f86fdf79 Fri Oct 02 14:52:44 CDT 2020 Chuck Lever <chuck.lever@oracle.com> NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The trade-off was:
- No support for an NFSD proc function returning a non-success RPC accept_stat value. - No support for void NFS replies to non-NULL procedures. - Everyone pays for the deduplication with a few extra conditional branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding the NFS status code into the NFS XDR encoders themselves. Then update the NFS .pc_func methods to return an RPC accept_stat value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|