Searched hist:c5f3014b82adc0e8f50bf5052031503d3467bea3 (Results 1 – 3 of 3) sorted by relevance
/openbmc/qemu/util/ |
H A D | qemu-config.c | diff c5f3014b82adc0e8f50bf5052031503d3467bea3 Thu Oct 06 04:33:17 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Add bdrv_runtime_opts to query-command-line-options
Recently we moved a few options from QemuOptsLists in blockdev.c to bdrv_runtime_opts in block.c in order to make them accissble using blockdev-add. However, this has the side effect that these options are missing from query-command-line-options now, and libvirt consequently disables the corresponding feature.
This problem was reported as a regression for the 'discard' option, introduced in commit 818584a4. However, it is more general than that.
Fix it by adding bdrv_runtime_opts to the list of QemuOptsLists that are returned in query-command-line-options. For the future, libvirt is advised to use QMP schema introspection for block device options.
Reported-by: Michal Privoznik <mprivozn@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Tested-by: Michal Privoznik <mprivozn@redhat.com> Tested-by: Gerd Hoffmann <kraxel@redhat.com>
|
/openbmc/qemu/include/sysemu/ |
H A D | sysemu.h | diff c5f3014b82adc0e8f50bf5052031503d3467bea3 Thu Oct 06 04:33:17 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Add bdrv_runtime_opts to query-command-line-options
Recently we moved a few options from QemuOptsLists in blockdev.c to bdrv_runtime_opts in block.c in order to make them accissble using blockdev-add. However, this has the side effect that these options are missing from query-command-line-options now, and libvirt consequently disables the corresponding feature.
This problem was reported as a regression for the 'discard' option, introduced in commit 818584a4. However, it is more general than that.
Fix it by adding bdrv_runtime_opts to the list of QemuOptsLists that are returned in query-command-line-options. For the future, libvirt is advised to use QMP schema introspection for block device options.
Reported-by: Michal Privoznik <mprivozn@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Tested-by: Michal Privoznik <mprivozn@redhat.com> Tested-by: Gerd Hoffmann <kraxel@redhat.com>
|
/openbmc/qemu/ |
H A D | block.c | diff c5f3014b82adc0e8f50bf5052031503d3467bea3 Thu Oct 06 04:33:17 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Add bdrv_runtime_opts to query-command-line-options
Recently we moved a few options from QemuOptsLists in blockdev.c to bdrv_runtime_opts in block.c in order to make them accissble using blockdev-add. However, this has the side effect that these options are missing from query-command-line-options now, and libvirt consequently disables the corresponding feature.
This problem was reported as a regression for the 'discard' option, introduced in commit 818584a4. However, it is more general than that.
Fix it by adding bdrv_runtime_opts to the list of QemuOptsLists that are returned in query-command-line-options. For the future, libvirt is advised to use QMP schema introspection for block device options.
Reported-by: Michal Privoznik <mprivozn@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Tested-by: Michal Privoznik <mprivozn@redhat.com> Tested-by: Gerd Hoffmann <kraxel@redhat.com>
|