Searched hist:b88d28146c30a8e14f0f012d56ebf19b68a348f4 (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/net/wireless/realtek/rtlwifi/ |
| H A D | debug.c | diff b88d28146c30a8e14f0f012d56ebf19b68a348f4 Tue May 17 06:48:44 CDT 2022 Dan Carpenter <dan.carpenter@oracle.com> wifi: rtlwifi: fix error codes in rtl_debugfs_set_write_h2c()
If the copy_from_user() fails or the user gives invalid date then the
correct thing to do is to return a negative error code. (Currently it
returns success).
I made a copy additional related cleanups:
1) There is no need to check "buffer" for NULL. That's handled by
copy_from_user().
2) The "h2c_len" variable cannot be negative because it is unsigned
and because sscanf() does not return negative error codes.
Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/YoOLnDkHgVltyXK7@kili
|