Home
last modified time | relevance | path

Searched hist:b2bbb642ac2829006a81ae164e2f06ebc22f81dd (Results 1 – 1 of 1) sorted by relevance

/openbmc/linux/drivers/s390/cio/
H A Dchsc_sch.cdiff b2bbb642ac2829006a81ae164e2f06ebc22f81dd Fri Oct 10 14:33:16 CDT 2008 Julia Lawall <julia@diku.dk> [S390] cio: Correct use of ! and &

In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337, a bug was fixed that
involved converting !x & y to !(x & y). The code below shows the same
pattern, and thus should perhaps be fixed in the same way. In particular,
the result of !scsw_stctl(&request->irb.scsw) & SCSW_STCTL_STATUS_PEND is
always just !scsw_stctl(&request->irb.scsw).

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E; constant C; @@
(
!E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>