Searched hist:a3ec4bb7e55956dc633e2248cf76f27d3b9c9c9d (Results 1 – 1 of 1) sorted by relevance
| /openbmc/qemu/hw/acpi/ |
| H A D | pcihp.c | diff a3ec4bb7e55956dc633e2248cf76f27d3b9c9c9d Thu Mar 26 08:56:24 CDT 2020 Igor Mammedov <imammedo@redhat.com> acpi: pcihp: fix left shift undefined behavior in acpi_pcihp_eject_slot()
Coverity spots subj in following guest triggered code path
pci_write(, data = 0) -> acpi_pcihp_eject_slot(,slots = 0)
uinst32_t slot = ctz32(slots)
...
... = ~(1U << slot)
where 'slot' value is 32 in case 'slots' bitmap is empty.
'slots' is a bitmap and empty one shouldn't do anything
so return early doing nothing if resulted slot value is
not valid (i.e. not in 0-31 range)
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20200326135624.32464-1-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|