Searched hist:a38a287ccaa97eddc9df7333e33357b14772d4c6 (Results 1 – 5 of 5) sorted by relevance
| /openbmc/phosphor-webui/app/common/services/ |
| H A D | dataService.js | diff 7920baeb036d499203d8b59516a2355eab9aba79 Thu May 23 11:45:49 CDT 2019 Gunnar Mills <gmills@us.ibm.com> Remove unused errors.html
Also removed errorModalDetails and displayErrorModal from
dataService since they are no longer used.
errors.html was only active when displayErrorModal was true.
displayErrorModal was only true when activateErrorModal was
called.
activateErrorModal was removed in a previous
commit. activateErrorModal's only use was removed here:
https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8
Tested: Searched the repo. Built an image and loaded onto a
Witherspoon. No regressions observed.
Change-Id: I96e26dd3817d7b02bbce74b4cc093b75dab669ed
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff f75dc93f3a35707a34937bd4186c7c9908892f42 Thu May 23 11:38:05 CDT 2019 Gunnar Mills <gmills@us.ibm.com> Remove unused activateErrorModal
activateErrorModal was unused. Also remove Constants.ERROR_MODAL
since activateErrorModal was the only place which used it.
https://github.com/openbmc/phosphor-webui/commit/a1d238f3a53db2ec3cc4c2fd52fe78738b37968b#diff-65affd2488457363c5b9e9266258c3b8
added activateErrorModal / deactivateErrorModal.
https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8
removed its use.
Tested: Searched the repo and when testing the GUI on a
a Witherspoon, toasts worked as expected.
Change-Id: I98107f397fab039123f8507cd7bbac2ef8e5fb7b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| H A D | constants.js | diff f75dc93f3a35707a34937bd4186c7c9908892f42 Thu May 23 11:38:05 CDT 2019 Gunnar Mills <gmills@us.ibm.com> Remove unused activateErrorModal
activateErrorModal was unused. Also remove Constants.ERROR_MODAL
since activateErrorModal was the only place which used it.
https://github.com/openbmc/phosphor-webui/commit/a1d238f3a53db2ec3cc4c2fd52fe78738b37968b#diff-65affd2488457363c5b9e9266258c3b8
added activateErrorModal / deactivateErrorModal.
https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8
removed its use.
Tested: Searched the repo and when testing the GUI on a
a Witherspoon, toasts worked as expected.
Change-Id: I98107f397fab039123f8507cd7bbac2ef8e5fb7b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| /openbmc/phosphor-webui/app/common/directives/ |
| H A D | app-header.js | diff a38a287ccaa97eddc9df7333e33357b14772d4c6 Thu Jun 07 01:04:58 CDT 2018 Jayashankar Padath <jayashankar.padath@in.ibm.com> Avoid unexpected error displays from web gui
Unexpected error is seen from the web gui due to the connection
loss during below known scenarios:
1. Initiating Reboot BMC from web gui
2. Restart of the nginx service
3. Trying to login to the web gui after a long idle time
Fix avoids unexpected error display from web gui.
Resolves openbmc/openbmc#3211
Tested: Running GUI locally and verified that unexpected error is not
coming when BMC reboots
Change-Id: I93974c53ab4fb414b938229d39fdf872b45a3e2c
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
|
| /openbmc/phosphor-webui/app/ |
| H A D | index.html | diff 7920baeb036d499203d8b59516a2355eab9aba79 Thu May 23 11:45:49 CDT 2019 Gunnar Mills <gmills@us.ibm.com> Remove unused errors.html
Also removed errorModalDetails and displayErrorModal from
dataService since they are no longer used.
errors.html was only active when displayErrorModal was true.
displayErrorModal was only true when activateErrorModal was
called.
activateErrorModal was removed in a previous
commit. activateErrorModal's only use was removed here:
https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8
Tested: Searched the repo. Built an image and loaded onto a
Witherspoon. No regressions observed.
Change-Id: I96e26dd3817d7b02bbce74b4cc093b75dab669ed
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| H A D | index.js | diff 7920baeb036d499203d8b59516a2355eab9aba79 Thu May 23 11:45:49 CDT 2019 Gunnar Mills <gmills@us.ibm.com> Remove unused errors.html
Also removed errorModalDetails and displayErrorModal from
dataService since they are no longer used.
errors.html was only active when displayErrorModal was true.
displayErrorModal was only true when activateErrorModal was
called.
activateErrorModal was removed in a previous
commit. activateErrorModal's only use was removed here:
https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8
Tested: Searched the repo. Built an image and loaded onto a
Witherspoon. No regressions observed.
Change-Id: I96e26dd3817d7b02bbce74b4cc093b75dab669ed
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|