Home
last modified time | relevance | path

Searched hist:"9 a0b1e8ba4061778897b544afc898de2163382f7" (Results 1 – 1 of 1) sorted by relevance

/openbmc/linux/net/core/
H A Dpktgen.cdiff 9a0b1e8ba4061778897b544afc898de2163382f7 Sat Oct 15 10:50:49 CDT 2016 Eric Dumazet <edumazet@google.com> net: pktgen: remove rcu locking in pktgen_change_name()

After Jesper commit back in linux-3.18, we trigger a lockdep
splat in proc_create_data() while allocating memory from
pktgen_change_name().

This patch converts t->if_lock to a mutex, since it is now only
used from control path, and adds proper locking to pktgen_change_name()

1) pktgen_thread_lock to protect the outer loop (iterating threads)
2) t->if_lock to protect the inner loop (iterating devices)

Note that before Jesper patch, pktgen_change_name() was lacking proper
protection, but lockdep was not able to detect the problem.

Fixes: 8788370a1d4b ("pktgen: RCU-ify "if_list" to remove lock in next_to_run()")
Reported-by: John Sperbeck <jsperbeck@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>