Searched hist:"93 d783bcca69bfacc8dc739d8a050498402587b5" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/hwmon/ |
| H A D | adt7470.c | diff 93d783bcca69bfacc8dc739d8a050498402587b5 Thu Aug 08 14:11:03 CDT 2013 Curt Brune <curt@cumulusnetworks.com> hwmon: (adt7470) Fix incorrect return code check
In adt7470_write_word_data(), which writes two bytes using
i2c_smbus_write_byte_data(), the return codes are incorrectly AND-ed
together when they should be OR-ed together.
The return code of i2c_smbus_write_byte_data() is zero for success.
The upshot is only the first byte was ever written to the hardware.
The 2nd byte was never written out.
I noticed that trying to set the fan speed limits was not working
correctly on my system. Setting the fan speed limits is the only
code that uses adt7470_write_word_data(). After making the change
the limit settings work and the alarms work also.
Signed-off-by: Curt Brune <curt@cumulusnetworks.com>
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
|