Searched hist:"864 f0f61f829bac5f150a903aad9619322a25424" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/fs/nfsd/ |
| H A D | nfsfh.c | diff 864f0f61f829bac5f150a903aad9619322a25424 Wed Nov 25 16:42:05 CST 2009 J. Bruce Fields <bfields@citi.umich.edu> nfsd: simplify fh_verify access checks
All nfsd security depends on the security checks in fh_verify, and
especially on nfsd_setuser().
It therefore bothers me that the nfsd_setuser call may be made from
three different places, depending on whether the filehandle has already
been mapped to a dentry, and on whether subtreechecking is in force.
Instead, make an unconditional call in fh_verify(), so it's trivial to
verify that the call always occurs.
That leaves us with a redundant nfsd_setuser() call in the subtreecheck
case--it needs the correct user set earlier in order to check execute
permissions on the path to this filehandle--but I'm willing to accept
that minor inefficiency in the subtreecheck case in return for more
straightforward permission checking.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
|