Searched hist:"8573823 f3ba2b63926f82d5732473e0cd73c1213" (Results 1 – 1 of 1) sorted by relevance
/openbmc/qemu/block/export/ |
H A D | export.c | diff 8573823f3ba2b63926f82d5732473e0cd73c1213 Thu Jun 24 03:38:24 CDT 2021 Max Reitz <mreitz@redhat.com> block/export: Conditionally ignore set-context error
When invoking block-export-add with some iothread and fixed-iothread=false, and changing the node's iothread fails, the error is supposed to be ignored.
However, it is still stored in *errp, which is wrong. If a second error occurs, the "*errp must be NULL" assertion in error_setv() fails:
qemu-system-x86_64: ../util/error.c:59: error_setv: Assertion `*errp == NULL' failed.
So if fixed-iothread=false, we should ignore the error by passing NULL to bdrv_try_set_aio_context().
Fixes: f51d23c80af73c95e0ce703ad06a300f1b3d63ef ("block/export: add iothread and fixed-iothread options") Signed-off-by: Max Reitz <mreitz@redhat.com> Message-Id: <20210624083825.29224-2-mreitz@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|