Searched hist:"7 f556567036cb7f89aabe2f0954b08566b4efb53" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/mm/ |
H A D | shmem.c | diff 7f556567036cb7f89aabe2f0954b08566b4efb53 Sun Jul 10 18:46:32 CDT 2016 Hugh Dickins <hughd@google.com> tmpfs: fix regression hang in fallocate undo
The well-spotted fallocate undo fix is good in most cases, but not when fallocate failed on the very first page. index 0 then passes lend -1 to shmem_undo_range(), and that has two bad effects: (a) that it will undo every fallocation throughout the file, unrestricted by the current range; but more importantly (b) it can cause the undo to hang, because lend -1 is treated as truncation, which makes it keep on retrying until every page has gone, but those already fully instantiated will never go away. Big thank you to xfstests generic/269 which demonstrates this.
Fixes: b9b4bb26af01 ("tmpfs: don't undo fallocate past its last page") Cc: stable@vger.kernel.org Signed-off-by: Hugh Dickins <hughd@google.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|