Home
last modified time | relevance | path

Searched hist:"7 e2cff42cfac27c25202648c5c89f9171e5bc085" (Results 1 – 2 of 2) sorted by relevance

/openbmc/linux/mm/
H A Dmprotect.cdiff 7e2cff42cfac27c25202648c5c89f9171e5bc085 Wed Sep 21 11:55:39 CDT 2005 Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> [PATCH] mm: add a note about partially hardcoded VM_* flags

Hugh made me note this line for permission checking in mprotect():

if ((newflags & ~(newflags >> 4)) & 0xf) {

after figuring out what's that about, I decided it's nasty enough. Btw
Hugh itself didn't like the 0xf.

We can safely change it to VM_READ|VM_WRITE|VM_EXEC because we never change
VM_SHARED, so no need to check that.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Acked-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
/openbmc/linux/include/linux/
H A Dmm.hdiff 7e2cff42cfac27c25202648c5c89f9171e5bc085 Wed Sep 21 11:55:39 CDT 2005 Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> [PATCH] mm: add a note about partially hardcoded VM_* flags

Hugh made me note this line for permission checking in mprotect():

if ((newflags & ~(newflags >> 4)) & 0xf) {

after figuring out what's that about, I decided it's nasty enough. Btw
Hugh itself didn't like the 0xf.

We can safely change it to VM_READ|VM_WRITE|VM_EXEC because we never change
VM_SHARED, so no need to check that.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Acked-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>