Searched hist:"7 d5b5261104235cd6cc86930ab0d0a7372bfe04b" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/qemu/ |
| H A D | block.c | diff 7d5b5261104235cd6cc86930ab0d0a7372bfe04b Wed Aug 23 08:42:42 CDT 2017 Stefan Hajnoczi <stefanha@redhat.com> block: Update open_flags after ->inactivate() callback
In the ->inactivate() callbacks, permissions are updated, which
typically involves a recursive check of the whole graph. Setting
BDRV_O_INACTIVE right before doing that creates a state that
bdrv_is_writable() returns false, which causes permission update
failure.
Reorder them so the flag is updated after calling the function. Note
that this doesn't break the assert in bdrv_child_cb_inactivate() because
for any specific BDS, we still update its flags first before calling
->inactivate() on it one level deeper in the recursion.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-Id: <20170823134242.12080-5-famz@redhat.com>
Tested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
|