Searched hist:"7 c96d46ec245d73fd76726588409f9abe4bd5dc1" (Results 1 – 1 of 1) sorted by relevance
/openbmc/qemu/ |
H A D | block.c | diff 4d70655bcb852ea0a006d3923f0b0a9c69ff462e Mon Mar 18 11:58:53 CDT 2013 Stefan Hajnoczi <stefanha@redhat.com> block: fix BDRV_O_SNAPSHOT protocol detection
realpath(3) is used to get an absolute path to the image file when creating a -drive snapshot=on temporary qcow2. This does not work for protocols since their filenames ("proto:foo:...") do not correspond to file system paths.
Commit 7c96d46ec245d73fd76726588409f9abe4bd5dc1 ("Let snapshot work with protocols") skipped realpath(3) for protocols. Later on the "raw" format was introduced and broke the check.
Use path_has_protocol(filename) to decide if this image uses a protocol or a filename.
Reported-by: Richard Jones <rjones@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> diff 7c96d46ec245d73fd76726588409f9abe4bd5dc1 Fri Sep 12 12:54:13 CDT 2008 aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162> Let snapshot work with protocols
realpath will horribly mangle a protocol so avoid calling it if the backing file is a protocol.
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5200 c046a42c-6fe2-441c-8c8c-71466251a162
|