Searched hist:"79 fdf63e2c4148593bb7aec4a3f471ade4c5cba0" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/bmcweb/redfish-core/lib/ |
| H A D | virtual_media.hpp | diff 70cbdf538e658a2d9591303b02da9d6b78002cd9 Fri Mar 03 22:07:25 CST 2023 George Liu <liuxiwei@inspur.com> Fix local CI failure issue
Error message:
redfish-core/lib/virtual_media.hpp:308:72: style: Parameter 'item'
can be declared as reference to const. However it seems that
'afterGetVmData' is a callback function, if 'item' is declared with
const you might also need to cast function pointer(s).
[constParameterCallback]
dbus::utility::DBusInteracesMap>& item)
^
redfish-core/lib/virtual_media.hpp:346:41: note: You might need to
cast the function pointer here
std::bind_front(&afterGetVmData, name));
^
redfish-core/lib/virtual_media.hpp:308:72: note: Parameter 'item' can
be declared as reference to const
dbus::utility::DBusInteracesMap>& item)
^
This regressed in commit: 79fdf63e2c4148593bb7aec4a3f471ade4c5cba0
Tested: Local CI passes
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia68e63ccaa069aedda01a11ce02aa2ef41021a07
diff 79fdf63e2c4148593bb7aec4a3f471ade4c5cba0 Tue Jun 28 11:11:59 CDT 2022 Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com> Extract out common parts
Some parts of backend validation is duplicated for different code paths.
This patch is an attempt to sort things out. Continuation of refactor
from the previous patch.
Tested:
Code change, behavior does not change.
Change-Id: I1f53c8c74584f7154567cd5cc507f213a96f4826
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>
|