Home
last modified time | relevance | path

Searched hist:"73 ea735073599430818e89b8901452287a15a718" (Results 1 – 2 of 2) sorted by relevance

/openbmc/linux/drivers/net/ethernet/microchip/sparx5/
H A Dsparx5_packet.cdiff 73ea735073599430818e89b8901452287a15a718 Thu Sep 29 13:19:47 CDT 2022 Nathan Huckleberry <nhuck@google.com> net: sparx5: Fix return type of sparx5_port_xmit_impl

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of sparx5_port_xmit_impl should be changed from int to
netdev_tx_t.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
H A Dsparx5_main.hdiff 73ea735073599430818e89b8901452287a15a718 Thu Sep 29 13:19:47 CDT 2022 Nathan Huckleberry <nhuck@google.com> net: sparx5: Fix return type of sparx5_port_xmit_impl

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of sparx5_port_xmit_impl should be changed from int to
netdev_tx_t.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>