Searched hist:"73 ce05302007eece23a6acb7dc124c92a2209087" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/rtc/ |
| H A D | rtc-pcf2127.c | diff 73ce05302007eece23a6acb7dc124c92a2209087 Tue Feb 08 10:29:07 CST 2022 Hugo Villeneuve <hvilleneuve@dimonoff.com> rtc: pcf2127: fix bug when reading alarm registers
The first bug is that reading the 5 alarm registers results in a read
operation of 20 bytes. The reason is because the destination buffer is
defined as an array of "unsigned int", and we use the sizeof()
operator on this array to define the bulk read count.
The second bug is that the read value is invalid, because we are
indexing the destination buffer as integers (4 bytes), instead of
indexing it as u8.
Changing the destination buffer type to u8 fixes both problems.
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220208162908.3182581-1-hugo@hugovil.com
|