Searched hist:"6 c0cf6022aeecf8f61279389c9ba7edc2f0986ca" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/scsi/ |
| H A D | sr_ioctl.c | diff 6c0cf6022aeecf8f61279389c9ba7edc2f0986ca Sun Jul 28 19:06:20 CDT 2024 Linus Torvalds <torvalds@linux-foundation.org> minmax: scsi: fix mis-use of 'clamp()' in sr.c
commit 9f499b8c791d2983c0a31a543c51d1b2f15e8755 upstream.
While working on simplifying the minmax functions, and avoiding
excessive macro expansion, it turns out that the sr.c use of the
'clamp()' macro has the arguments the wrong way around.
The clamp logic is
val = clamp(in, low, high);
and it returns the input clamped to the low/high limits. But sr.c ddid
speed = clamp(0, speed, 0xffff / 177);
which clamps the value '0' to the range '[speed, 0xffff / 177]' and ends
up being nonsensical.
Happily, I don't think anybody ever cared.
Fixes: 9fad9d560af5 ("scsi: sr: Fix unintentional arithmetic wraparound")
Cc: Justin Stitt <justinstitt@google.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Wentao Guan <guanwentao@uniontech.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|