Home
last modified time | relevance | path

Searched hist:"6 ba8ecf9aa4e0ebf400b6e3e00e580569a623e58" (Results 1 – 1 of 1) sorted by relevance

/openbmc/linux/tools/testing/ktest/
H A Dktest.pldiff 6ba8ecf9aa4e0ebf400b6e3e00e580569a623e58 Wed Sep 04 12:55:30 CDT 2024 Daniel Jordan <daniel.m.jordan@oracle.com> ktest.pl: Avoid false positives with grub2 skip regex

[ Upstream commit 2351e8c65404aabc433300b6bf90c7a37e8bbc4d ]

Some distros have grub2 config files with the lines

if [ x"${feature_menuentry_id}" = xy ]; then
menuentry_id_option="--id"
else
menuentry_id_option=""
fi

which match the skip regex defined for grub2 in get_grub_index():

$skip = '^\s*menuentry';

These false positives cause the grub number to be higher than it
should be, and the wrong kernel can end up booting.

Grub documents the menuentry command with whitespace between it and the
title, so make the skip regex reflect this.

Link: https://lore.kernel.org/20240904175530.84175-1-daniel.m.jordan@oracle.com
Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Acked-by: John 'Warthog9' Hawley (Tenstorrent) <warthog9@eaglescrag.net>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>