Searched hist:"6 a480a7842545ec520a91730209ec0bae41694c1" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/fs/ecryptfs/ |
| H A D | file.c | diff 6a480a7842545ec520a91730209ec0bae41694c1 Wed May 04 13:04:13 CDT 2016 Al Viro <viro@zeniv.linux.org.uk> ecryptfs: fix handling of directory opening
First of all, trying to open them r/w is idiocy; it's guaranteed to fail.
Moreover, assigning ->f_pos and assuming that everything will work is
blatantly broken - try that with e.g. tmpfs as underlying layer and watch
the fireworks. There may be a non-trivial amount of state associated with
current IO position, well beyond the numeric offset. Using the single
struct file associated with underlying inode is really not a good idea;
we ought to open one for each ecryptfs directory struct file.
Additionally, file_operations both for directories and non-directories are
full of pointless methods; non-directories should *not* have ->iterate(),
directories should not have ->flush(), ->fasync() and ->splice_read().
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
|