Searched hist:"6 a1a3b9f686bb04820a232cc1657ef2c45670709" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/net/core/ |
H A D | net_namespace.c | diff 45a19b0a725a04f3255d9d3da1fca30bb97f1481 Wed Nov 07 03:30:30 CST 2007 Johann Felix Soden <johfel@users.sourceforge.net> [NETNS]: Fix compiler error in net_namespace.c
Because net_free is called by copy_net_ns before its declaration, the compiler gives an error. This patch puts net_free before copy_net_ns to fix this.
The compiler error: net/core/net_namespace.c: In function 'copy_net_ns': net/core/net_namespace.c:97: error: implicit declaration of function 'net_free' net/core/net_namespace.c: At top level: net/core/net_namespace.c:104: warning: conflicting types for 'net_free' net/core/net_namespace.c:104: error: static declaration of 'net_free' follows non-static declaration net/core/net_namespace.c:97: error: previous implicit declaration of 'net_free' was here
The error was introduced by the '[NET]: Hide the dead code in the net_namespace.c' patch (6a1a3b9f686bb04820a232cc1657ef2c45670709).
Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net> Signed-off-by: David S. Miller <davem@davemloft.net> diff 6a1a3b9f686bb04820a232cc1657ef2c45670709 Thu Nov 01 02:44:50 CDT 2007 Pavel Emelyanov <xemul@openvz.org> [NET]: Hide the dead code in the net_namespace.c
The namespace creation/destruction code is never called if the CONFIG_NET_NS is n, so it's OK to move it under appropriate ifdef.
The copy_net_ns() in the "n" case checks for flags and returns -EINVAL when new net ns is requested. In a perfect world this stub must be in net_namespace.h, but this function need to know the CLONE_NEWNET value and thus requires sched.h. On the other hand this header is to be injected into almost every .c file in the networking code, and making all this code depend on the sched.h is a suicidal attempt.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org> Signed-off-by: David S. Miller <davem@davemloft.net>
|