Searched hist:"612 aea201738cd747b02d2c2acd6e0bf406531cf" (Results 1 – 1 of 1) sorted by relevance
/openbmc/qemu/ui/ |
H A D | vnc.c | diff 612aea201738cd747b02d2c2acd6e0bf406531cf Wed Oct 17 03:26:51 CDT 2018 Markus Armbruster <armbru@redhat.com> vnc: Clean up error reporting in vnc_init_func()
Calling error_report() in a function that takes an Error ** argument is suspicious. vnc_init_func() does that, and then fails without setting an error. Its caller main(), via qemu_opts_foreach(), is fine with it, but clean it up anyway.
While there, drop a "Failed to start VNC server: " error message prefix that doesn't really add value.
Cc: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20181017082702.5581-28-armbru@redhat.com> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
|