Searched hist:"5 bcc0dd7906758ad9b37ce66835e5b53e15d9b1d" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/drivers/media/usb/go7007/ |
H A D | go7007-fw.c | diff 5bcc0dd7906758ad9b37ce66835e5b53e15d9b1d Wed Sep 16 18:55:04 CDT 2015 Javier Martinez Canillas <javier@osg.samsung.com> [media] go7007: Fix returned errno code in gen_mjpeghdr_to_package()
The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Since the error number is propagated, the caller will get a -EPERM which is the wrong error condition.
Also, the smatch tool complains with the following warning:
gen_mjpeghdr_to_package() warn: returning -1 instead of -ENOMEM is sloppy
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
|