Searched hist:"527 ff346907354a2ce03678c1c2a523108e8b4bc" (Results 1 – 2 of 2) sorted by relevance
| /openbmc/phosphor-logging/extensions/openpower-pels/ |
| H A D | pldm_interface.cpp | diff 527ff346907354a2ce03678c1c2a523108e8b4bc Thu Jun 29 12:52:34 CDT 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle failing to start a PLDM cmd better
A recent PLDM bug caused the registerReceiveCallback() function, which
is used to setup listening for the PLDM response from the host when
telling them about a new PEL, to throw an exception.
When this happened, the code got stuck in the 'in progress' state, so it
would never try again when the next PEL came in.
Fix that by having startCommand() throw an exception instead of calling
the failure response function callback. With this change, the code will
continue on to call the cleanupCmd() function so everything is ready
when the next PEL comes in.
Tested:
With the bad PLDM code, after the first PEL ran out of retry attempts,
created another PEL and saw the code attempt again to call PLDM. Also,
wrote a new unit test case for it.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I38034440435d6a86e8dd880eef09499f19dd6e9c
|
| /openbmc/phosphor-logging/test/openpower-pels/ |
| H A D | host_notifier_test.cpp | diff 527ff346907354a2ce03678c1c2a523108e8b4bc Thu Jun 29 12:52:34 CDT 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle failing to start a PLDM cmd better
A recent PLDM bug caused the registerReceiveCallback() function, which
is used to setup listening for the PLDM response from the host when
telling them about a new PEL, to throw an exception.
When this happened, the code got stuck in the 'in progress' state, so it
would never try again when the next PEL came in.
Fix that by having startCommand() throw an exception instead of calling
the failure response function callback. With this change, the code will
continue on to call the cleanupCmd() function so everything is ready
when the next PEL comes in.
Tested:
With the bad PLDM code, after the first PEL ran out of retry attempts,
created another PEL and saw the code attempt again to call PLDM. Also,
wrote a new unit test case for it.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I38034440435d6a86e8dd880eef09499f19dd6e9c
|