Searched hist:"50 fb4f7fc907efff65eadb0b74387a9ffed6e849" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/kernel/ |
| H A D | freezer.c | diff 50fb4f7fc907efff65eadb0b74387a9ffed6e849 Mon Nov 21 14:32:22 CST 2011 Tejun Heo <tj@kernel.org> freezer: fix current->state restoration race in refrigerator()
refrigerator() saves current->state before entering frozen state and
restores it before returning using __set_current_state(); however,
this is racy, for example, please consider the following sequence.
set_current_state(TASK_INTERRUPTIBLE);
try_to_freeze();
if (kthread_should_stop())
break;
schedule();
If kthread_stop() races with ->state restoration, the restoration can
restore ->state to TASK_INTERRUPTIBLE after kthread_stop() sets it to
TASK_RUNNING but kthread_should_stop() may still see zero
->should_stop because there's no memory barrier between restoring
TASK_INTERRUPTIBLE and kthread_should_stop() test.
This isn't restricted to kthread_should_stop(). current->state is
often used in memory barrier based synchronization and silently
restoring it w/o mb breaks them.
Use set_current_state() instead.
Signed-off-by: Tejun Heo <tj@kernel.org>
|