Searched hist:"4 eb14e3fc6197b7205069ed4e2b31eafa11a0697" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/net/ethernet/sfc/ |
| H A D | rx.c | diff 4eb14e3fc6197b7205069ed4e2b31eafa11a0697 Thu Jun 24 11:06:06 CDT 2021 Toke Høiland-Jørgensen <toke@redhat.com> sfc: Remove rcu_read_lock() around XDP program invocation
The sfc driver has rcu_read_lock()/rcu_read_unlock() pairs around XDP
program invocations. However, the actual lifetime of the objects referred
by the XDP program invocation is longer, all the way through to the call to
xdp_do_flush(), making the scope of the rcu_read_lock() too small. This
turns out to be harmless because it all happens in a single NAPI poll
cycle (and thus under local_bh_disable()), but it makes the rcu_read_lock()
misleading.
Rather than extend the scope of the rcu_read_lock(), just get rid of it
entirely. With the addition of RCU annotations to the XDP_REDIRECT map
types that take bh execution into account, lockdep even understands this to
be safe, so there's really no reason to keep it around.
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Cc: Martin Habets <habetsm.xilinx@gmail.com>
Link: https://lore.kernel.org/bpf/20210624160609.292325-17-toke@redhat.com
|