Home
last modified time | relevance | path

Searched hist:"4 ccd3329a2e51473a86547a55f9e5f98f8f65b33" (Results 1 – 1 of 1) sorted by relevance

/openbmc/linux/drivers/ata/
H A Dlibata-eh.cdiff 4ccd3329a2e51473a86547a55f9e5f98f8f65b33 Tue Jan 08 05:26:12 CST 2008 Tejun Heo <htejun@gmail.com> libata: don't normalize UNKNOWN to NONE after reset

After non-classifying reset, ehc->classes[] could contain
ATA_DEV_UNKNOWN which used to be normalized to ATA_DEV_NONE for
consistency. However, this causes unfortunate side effect for drivers
which have non-classifying hardresets (e.g. sata_nv) by making
hardreset report ATA_DEV_NONE for non-classifying resets and thus
makes EH believe that the port is unoccupied and recovery can be
skipped. The end result is that after a device is swapped with
another one, the new device isn't attached after the old one is
detached.

This patch makes ata_eh_reset() not normalize UNKNOWN to NONE after
non-classifying resets. This fixes the above problem. As UNKNOWN and
NONE are handled differently by only EH hotplug logic, this doesn't
cause other behavior changes.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Robert Hancock <hancockr@shaw.ca>
Signed-off-by: Jeff Garzik <jeff@garzik.org>