Searched hist:"4 a8108b70508df0b6c4ffa4a3974dab93dcbe851" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/arch/arm64/crypto/ |
H A D | aes-neonbs-glue.c | diff 4a8108b70508df0b6c4ffa4a3974dab93dcbe851 Wed Apr 10 01:46:32 CDT 2019 Eric Biggers <ebiggers@google.com> crypto: arm64/aes-neonbs - don't access already-freed walk.iv
If the user-provided IV needs to be aligned to the algorithm's alignmask, then skcipher_walk_virt() copies the IV into a new aligned buffer walk.iv. But skcipher_walk_virt() can fail afterwards, and then if the caller unconditionally accesses walk.iv, it's a use-after-free.
xts-aes-neonbs doesn't set an alignmask, so currently it isn't affected by this despite unconditionally accessing walk.iv. However this is more subtle than desired, and unconditionally accessing walk.iv has caused a real problem in other algorithms. Thus, update xts-aes-neonbs to start checking the return value of skcipher_walk_virt().
Fixes: 1abee99eafab ("crypto: arm64/aes - reimplement bit-sliced ARM/NEON implementation for arm64") Cc: <stable@vger.kernel.org> # v4.11+ Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
|