Home
last modified time | relevance | path

Searched hist:"40 f4b1f031a71dcf111f64a3c20ee0361b96d862" (Results 1 – 1 of 1) sorted by relevance

/openbmc/linux/drivers/iio/accel/
H A Dhid-sensor-accel-3d.cdiff 40f4b1f031a71dcf111f64a3c20ee0361b96d862 Thu May 04 15:10:52 CDT 2017 Julia Lawall <Julia.Lawall@lip6.fr> iio: hid-sensor-accel-3d: Drop unnecessary static

Drop static on a local variable, when the variable is initialized before
use, on every possible execution path through the function. The static has
no benefit, and dropping it reduces the code size.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
T x@p;
... when != x
when strict
?x = e;
// </smpl>

The change in code size is indicates by the following output from the size
command.

before:
text data bss dec hex filename
3879 512 8 4399 112f drivers/iio/accel/hid-sensor-accel-3d.o

after:
text data bss dec hex filename
3863 512 0 4375 1117 drivers/iio/accel/hid-sensor-accel-3d.o

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>