Searched hist:"3 d0db3e74d818ba43c62cdfb3220e551f4f5ae37" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/qemu/hw/ppc/ |
| H A D | spapr_rng.c | diff 3d0db3e74d818ba43c62cdfb3220e551f4f5ae37 Thu Feb 25 05:08:00 CST 2016 Greg Kurz <gkurz@linux.vnet.ibm.com> spapr_rng: disable hotpluggability
It is currently possible to hotplug a spapr_rng device but QEMU crashes
when we try to hot unplug:
ERROR:hw/core/qdev.c:295:qdev_unplug: assertion failed: (hotplug_ctrl)
Aborted
This happens because spapr_rng isn't plugged to any bus and sPAPR does
not provide hotplug support for it: qdev_get_hotplug_handler() hence
return NULL and we hit the assertion.
And anyway, it doesn't make much sense to unplug this device since hcalls
cannot be unregistered. Even the idea of hotplugging a RNG device instead
of declaring it on the QEMU command line looks weird.
This patch simply disables hotpluggability for the spapr-rng class.
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
|