Searched hist:"34 afa1d657d4742c9bce4a4c197ebf61b4af1b9e" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/misc/ |
| H A D | pch_phub.c | diff 34afa1d657d4742c9bce4a4c197ebf61b4af1b9e Mon Jun 29 03:15:31 CDT 2020 Vaibhav Gupta <vaibhavgupta40@gmail.com> misc/pch_phub.c: use generic power management
Drivers should not use legacy power management as they have to manage power
states and related operations, for the device, themselves. This driver was
handling them with the help of PCI helper functions like
pci_save/restore_state(), pci_enable/disable_device(), etc.
With generic PM, all essentials will be handled by the PCI core. Driver
needs to do only device-specific operations.
The driver was also using pci_enable_wake(...,..., 0) to disable wake. Use
device_wakeup_disable() instead. It was also saving device register
configuration using pch_phub_save/restore_reg_conf() which is not
recommended.
Compile-tested only.
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Link: https://lore.kernel.org/r/20200629081531.214734-6-vaibhavgupta40@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|