Searched hist:"2 a7e6857cd3178d705a49c4adde2f3af26ed3ae1" (Results 1 – 1 of 1) sorted by relevance
/openbmc/qemu/ui/ |
H A D | vnc.c | diff 2a7e6857cd3178d705a49c4adde2f3af26ed3ae1 Fri Feb 03 06:06:43 CST 2017 Daniel P. Berrange <berrange@redhat.com> ui: fix reporting of VNC auth in query-vnc-servers
Currently the VNC authentication info is emitted at the top level of the query-vnc-servers data. This is wrong because the authentication scheme differs between plain and websockets when TLS is enabled. We should instead report auth against the individual servers. e.g.
(QEMU) query-vnc-servers { "return": [ { "clients": [], "id": "default", "auth": "vencrypt", "vencrypt": "x509-vnc", "server": [ { "host": "127.0.0.1" "service": "5901", "websocket": false, "family": "ipv4", "auth": "vencrypt", "vencrypt": "x509-vnc" }, { "host": "127.0.0.1", "service": "5902", "websocket": true, "family": "ipv4", "auth": "vnc" } ] } ] }
This also future proofs the QMP schema so that we can cope with multiple VNC server instances, listening on different interfaces or ports, with different auth setup.
Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Daniel P. Berrange <berrange@redhat.com> Message-id: 20170203120649.15637-3-berrange@redhat.com Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|