Home
last modified time | relevance | path

Searched hist:"2 a078b1080917dc6143783e1dd645e188d11dc8f" (Results 1 – 1 of 1) sorted by relevance

/openbmc/qemu/hw/i386/
H A Dintel_iommu.cdiff 2a078b1080917dc6143783e1dd645e188d11dc8f Tue Jan 15 21:08:12 CST 2019 Peter Xu <peterx@redhat.com> intel_iommu: fix operator in vtd_switch_address_space

When calculating use_iommu, we wanted to first detect whether DMAR is
enabled, then check whether PT is enabled if DMAR is enabled. However
in the current code we used "&" rather than "&&" so the ordering
requirement is lost (instead it'll be an "AND" operation). This could
introduce errors dumped in QEMU console when rebooting a guest with
both assigned device and vIOMMU, like:

qemu-system-x86_64: vtd_dev_to_context_entry: invalid root entry:
rsvd=0xf000ff53f000e2c3, val=0xf000ff53f000ff53 (reserved nonzero)

Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>