| /openbmc/qemu/block/ |
| H A D | throttle-groups.c | diff 6bf77e1c2dc24da1bade16e8a9a637f3b127314d Mon Oct 17 10:46:02 CDT 2016 Alberto Garcia <berto@igalia.com> throttle: Correct access to wrong BlockBackendPublic structures
In 27ccdd52598290f0f8b58be56e235aff7aebfaf3 the throttling fields were
moved from BlockDriverState to BlockBackend. However in a few cases
the code started using throttling fields from the active BlockBackend
instead of the round-robin token, making the algorithm behave
incorrectly.
This can cause starvation if there's a throttling group with several
drives but only one of them has I/O.
Cc: qemu-stable@nongnu.org
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
diff 27ccdd52598290f0f8b58be56e235aff7aebfaf3 Mon Mar 21 06:56:44 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Move throttling fields from BDS to BB
This patch changes where the throttling state is stored (used to be the
BlockDriverState, now it is the BlockBackend), but it doesn't actually
make it a BB level feature yet. For example, throttling is still
disabled when the BDS is detached from the BB.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
| H A D | qapi.c | diff 27ccdd52598290f0f8b58be56e235aff7aebfaf3 Mon Mar 21 06:56:44 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Move throttling fields from BDS to BB
This patch changes where the throttling state is stored (used to be the
BlockDriverState, now it is the BlockBackend), but it doesn't actually
make it a BB level feature yet. For example, throttling is still
disabled when the BDS is detached from the BB.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
| H A D | block-backend.c | diff 27ccdd52598290f0f8b58be56e235aff7aebfaf3 Mon Mar 21 06:56:44 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Move throttling fields from BDS to BB
This patch changes where the throttling state is stored (used to be the
BlockDriverState, now it is the BlockBackend), but it doesn't actually
make it a BB level feature yet. For example, throttling is still
disabled when the BDS is detached from the BB.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
| H A D | io.c | diff 27ccdd52598290f0f8b58be56e235aff7aebfaf3 Mon Mar 21 06:56:44 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Move throttling fields from BDS to BB
This patch changes where the throttling state is stored (used to be the
BlockDriverState, now it is the BlockBackend), but it doesn't actually
make it a BB level feature yet. For example, throttling is still
disabled when the BDS is detached from the BB.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
| /openbmc/qemu/include/block/ |
| H A D | throttle-groups.h | diff 27ccdd52598290f0f8b58be56e235aff7aebfaf3 Mon Mar 21 06:56:44 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Move throttling fields from BDS to BB
This patch changes where the throttling state is stored (used to be the
BlockDriverState, now it is the BlockBackend), but it doesn't actually
make it a BB level feature yet. For example, throttling is still
disabled when the BDS is detached from the BB.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
| H A D | block_int.h | diff 27ccdd52598290f0f8b58be56e235aff7aebfaf3 Mon Mar 21 06:56:44 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Move throttling fields from BDS to BB
This patch changes where the throttling state is stored (used to be the
BlockDriverState, now it is the BlockBackend), but it doesn't actually
make it a BB level feature yet. For example, throttling is still
disabled when the BDS is detached from the BB.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
| /openbmc/qemu/include/sysemu/ |
| H A D | block-backend.h | diff 27ccdd52598290f0f8b58be56e235aff7aebfaf3 Mon Mar 21 06:56:44 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Move throttling fields from BDS to BB
This patch changes where the throttling state is stored (used to be the
BlockDriverState, now it is the BlockBackend), but it doesn't actually
make it a BB level feature yet. For example, throttling is still
disabled when the BDS is detached from the BB.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
| /openbmc/qemu/ |
| H A D | blockdev.c | diff 27ccdd52598290f0f8b58be56e235aff7aebfaf3 Mon Mar 21 06:56:44 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Move throttling fields from BDS to BB
This patch changes where the throttling state is stored (used to be the
BlockDriverState, now it is the BlockBackend), but it doesn't actually
make it a BB level feature yet. For example, throttling is still
disabled when the BDS is detached from the BB.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
| H A D | block.c | diff 27ccdd52598290f0f8b58be56e235aff7aebfaf3 Mon Mar 21 06:56:44 CDT 2016 Kevin Wolf <kwolf@redhat.com> block: Move throttling fields from BDS to BB
This patch changes where the throttling state is stored (used to be the
BlockDriverState, now it is the BlockBackend), but it doesn't actually
make it a BB level feature yet. For example, throttling is still
disabled when the BDS is detached from the BB.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|