Searched hist:"251 b7aea34ba3c4d4fdfa9447695642eb8b8b098" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/crypto/ |
| H A D | pcbc.c | diff 251b7aea34ba3c4d4fdfa9447695642eb8b8b098 Thu Jan 03 22:16:13 CST 2019 Eric Biggers <ebiggers@google.com> crypto: pcbc - remove bogus memcpy()s with src == dest
The memcpy()s in the PCBC implementation use walk->iv as both the source
and destination, which has undefined behavior. These memcpy()'s are
actually unneeded, because walk->iv is already used to hold the previous
plaintext block XOR'd with the previous ciphertext block. Thus,
walk->iv is already updated to its final value.
So remove the broken and unnecessary memcpy()s.
Fixes: 91652be5d1b9 ("[CRYPTO] pcbc: Add Propagated CBC template")
Cc: <stable@vger.kernel.org> # v2.6.21+
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
|