Searched hist:"239 ac7faeaeaff395ccd4ef43b14bd85c56131bb" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/net/wireless/realtek/rtw89/ |
| H A D | phy.c | diff 239ac7faeaeaff395ccd4ef43b14bd85c56131bb Fri Aug 09 02:20:10 CDT 2024 Ping-Ke Shih <pkshih@realtek.com> wifi: rtw89: correct base HT rate mask for firmware
[ Upstream commit 45742881f9eee2a4daeb6008e648a460dd3742cd ]
Coverity reported that u8 rx_mask << 24 will become signed 32 bits, which
casting to unsigned 64 bits will do sign extension. For example,
putting 0x80000000 (signed 32 bits) to a u64 variable will become
0xFFFFFFFF_80000000.
The real case we meet is:
rx_mask[0...3] = ff ff 00 00
ra_mask = 0xffffffff_ff0ff000
After this fix:
rx_mask[0...3] = ff ff 00 00
ra_mask = 0x00000000_ff0ff000
Fortunately driver does bitwise-AND with incorrect ra_mask and supported
rates (1ss and 2ss rate only) afterward, so the final rate mask of
original code is still correct.
Addresses-Coverity-ID: 1504762 ("Unintended sign extension")
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20240809072012.84152-5-pkshih@realtek.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
|