Searched hist:"1 d9e689c934bd5ecb0f273c6c65e0655c5cfee5f" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/tty/ |
| H A D | tty_port.c | diff 1d9e689c934bd5ecb0f273c6c65e0655c5cfee5f Thu Jul 25 00:26:16 CDT 2013 Gianluca Anzolin <gianluca@sottospazio.it> tty_port: Fix refcounting leak in tty_port_tty_hangup()
The function tty_port_tty_hangup() could leak a reference to the tty_struct:
struct tty_struct *tty = tty_port_tty_get(port);
if (tty && (!check_clocal || !C_CLOCAL(tty))) {
tty_hangup(tty);
tty_kref_put(tty);
}
If tty != NULL and the second condition is false we never call tty_kref_put and
the reference is leaked.
Fix by always calling tty_kref_put() which accepts a NULL argument.
The patch fixes a regression introduced by commit aa27a094.
Acked-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: Gianluca Anzolin <gianluca@sottospazio.it>
Acked-by: Jiri Slaby <jslaby@suse.cz>
Cc: stable <stable@vger.kernel.org> # 3.10
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|