Searched hist:"1 d4aaf16defa86d2665ae7db0259d6cb07e2091f" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/arch/arm64/crypto/ |
H A D | sha1-ce-glue.c | diff 1d4aaf16defa86d2665ae7db0259d6cb07e2091f Tue May 28 07:41:52 CDT 2019 Elena Petrova <lenaptr@google.com> crypto: arm64/sha1-ce - correct digest for empty data in finup
The sha1-ce finup implementation for ARM64 produces wrong digest for empty input (len=0). Expected: da39a3ee..., result: 67452301... (initial value of SHA internal state). The error is in sha1_ce_finup: for empty data `finalize` will be 1, so the code is relying on sha1_ce_transform to make the final round. However, in sha1_base_do_update, the block function will not be called when len == 0.
Fix it by setting finalize to 0 if data is empty.
Fixes: 07eb54d306f4 ("crypto: arm64/sha1-ce - move SHA-1 ARMv8 implementation to base layer") Cc: stable@vger.kernel.org Signed-off-by: Elena Petrova <lenaptr@google.com> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
|