Searched hist:"1 a823ac9ff09cbdf39201df37b7ede1f9395de83" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/fs/fuse/ |
| H A D | dir.c | diff 1a823ac9ff09cbdf39201df37b7ede1f9395de83 Sat Feb 23 17:23:27 CST 2008 Miklos Szeredi <mszeredi@suse.cz> fuse: fix permission checking
I added a nasty local variable shadowing bug to fuse in 2.6.24, with the
result, that the 'default_permissions' mount option is basically ignored.
How did this happen?
- old err declaration in inner scope
- new err getting declared in outer scope
- 'return err' from inner scope getting removed
- old declaration not being noticed
-Wshadow would have saved us, but it doesn't seem practical for
the kernel :(
More testing would have also saved us :((
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|