Home
last modified time | relevance | path

Searched hist:"0 ed95d769c8d6c1030dd9f94cf6fb2a6ed98a4ce" (Results 1 – 1 of 1) sorted by relevance

/openbmc/linux/sound/soc/intel/skylake/
H A Dskl-topology.cdiff 0ed95d769c8d6c1030dd9f94cf6fb2a6ed98a4ce Fri Nov 13 07:52:11 CST 2015 Jeeja KP <jeeja.kp@intel.com> ASoC: Intel: Skylake: Fix null ptr dereferenced in skl_tplg_bind_sinks

This patch fixes the below warning form smatch and makes the
skl_tplg_bind_sinks take the next sink as argument which is true
when the current sink is valid

sound/soc/intel/skylake/skl-topology.c:453 skl_tplg_bind_sinks()
error: we previously assumed 'sink' could be null (see line 452)

sound/soc/intel/skylake/skl-topology.c
451
452 if (!sink)
^^^^
New check. Reversed?

453 return skl_tplg_bind_sinks(sink, skl, src_mconfig);
^^^^ This is
dereferenced inside the function.

454
455 return 0;

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>