| /openbmc/openpower-proc-control/service_files/ |
| H A D | op-reset-host-check@.service.in | diff 971b36d18276a05b30d3ac5af9a793ce38a57a77 Wed Sep 01 17:00:49 CDT 2021 Andrew Geissler <geissonator@yahoo.com> op-reset-host-check: update for recent state mgr changes
The following commit refactored the way the host state is discovered
when the BMC is reset and the host is running:
https://github.com/openbmc/phosphor-state-manager/commit/0d1c3f1f9329c853677f0581287afef83eeea0f0
All of the discovery now happens in the
xyz.openbmc_project.State.Host.service so set the appropriate dependency
on that.
Tested:
- Did a chassis power on, set the CFAM register to indicate host is
running, and rebooted the BMC. Verified that service ran after the
host had been probed over IPMI and PLDM and appropriate error was
logged.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I02fab25a4a2ed2b093bc45a5a68fca0507b3dce6
|
| /openbmc/phosphor-state-manager/service_files/ |
| H A D | phosphor-reset-sensor-states@.service | diff 0d1c3f1f9329c853677f0581287afef83eeea0f0 Tue Jul 27 15:21:01 CDT 2021 Andrew Geissler <geissonator@yahoo.com> host-check: discover host state within state manager
Currently the phosphor-host-state-manager is started before the logic
has run to detect if the host is already running. This results in
phosphor-host-state-manager temporarily reporting that the host is not
running, even if it actually is. This can cause confusion for clients
monitoring this property.
The solution is to move the logic which discovers if the host is running
into phosphor-host-state-manager. Having the logic to do this in a
separate application was a nice separation of concerns but when the
requirement is a co-req, best to just combine them.
This change results in the phosphor-host-state-manager service starting
later in the boot to BMC Ready but testing has shown no impacts to
overall time to reach BMC Ready or impacts to other services.
As a part of this change, the phosphor-reset-sensor-states service was
moved out of the obmc-host-reset target to ensure it and the
phosphor-host-state-manager service have the correct dependency between
them. The phosphor-host-state-manager service now ensures it runs after
the pldm and ipmi services if they are being started (they are
utilized to check if the host is running).
Testing:
- Chassis On, Host On
Jul 30 14:40:37 rainxxx phosphor-host-state-manager[696]: Check if host is running
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Host is running!
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Initial Host State will be Running
- Chassis Off, Host Off
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Check if host is running
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Chassis power not on, exit
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Initial Host State will be Off
- Chassis On, Host Off
Jul 30 14:57:11 rainxxx phosphor-host-state-manager[1193]: Check if host is running
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Host is not running!
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Initial Host State will be Off
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I938902f526fba2f857be4b21b01149f8250b972d
|
| H A D | meson.build | diff 0d1c3f1f9329c853677f0581287afef83eeea0f0 Tue Jul 27 15:21:01 CDT 2021 Andrew Geissler <geissonator@yahoo.com> host-check: discover host state within state manager
Currently the phosphor-host-state-manager is started before the logic
has run to detect if the host is already running. This results in
phosphor-host-state-manager temporarily reporting that the host is not
running, even if it actually is. This can cause confusion for clients
monitoring this property.
The solution is to move the logic which discovers if the host is running
into phosphor-host-state-manager. Having the logic to do this in a
separate application was a nice separation of concerns but when the
requirement is a co-req, best to just combine them.
This change results in the phosphor-host-state-manager service starting
later in the boot to BMC Ready but testing has shown no impacts to
overall time to reach BMC Ready or impacts to other services.
As a part of this change, the phosphor-reset-sensor-states service was
moved out of the obmc-host-reset target to ensure it and the
phosphor-host-state-manager service have the correct dependency between
them. The phosphor-host-state-manager service now ensures it runs after
the pldm and ipmi services if they are being started (they are
utilized to check if the host is running).
Testing:
- Chassis On, Host On
Jul 30 14:40:37 rainxxx phosphor-host-state-manager[696]: Check if host is running
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Host is running!
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Initial Host State will be Running
- Chassis Off, Host Off
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Check if host is running
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Chassis power not on, exit
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Initial Host State will be Off
- Chassis On, Host Off
Jul 30 14:57:11 rainxxx phosphor-host-state-manager[1193]: Check if host is running
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Host is not running!
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Initial Host State will be Off
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I938902f526fba2f857be4b21b01149f8250b972d
|
| /openbmc/phosphor-state-manager/ |
| H A D | host_check.hpp | 0d1c3f1f9329c853677f0581287afef83eeea0f0 Tue Jul 27 15:21:01 CDT 2021 Andrew Geissler <geissonator@yahoo.com> host-check: discover host state within state manager
Currently the phosphor-host-state-manager is started before the logic
has run to detect if the host is already running. This results in
phosphor-host-state-manager temporarily reporting that the host is not
running, even if it actually is. This can cause confusion for clients
monitoring this property.
The solution is to move the logic which discovers if the host is running
into phosphor-host-state-manager. Having the logic to do this in a
separate application was a nice separation of concerns but when the
requirement is a co-req, best to just combine them.
This change results in the phosphor-host-state-manager service starting
later in the boot to BMC Ready but testing has shown no impacts to
overall time to reach BMC Ready or impacts to other services.
As a part of this change, the phosphor-reset-sensor-states service was
moved out of the obmc-host-reset target to ensure it and the
phosphor-host-state-manager service have the correct dependency between
them. The phosphor-host-state-manager service now ensures it runs after
the pldm and ipmi services if they are being started (they are
utilized to check if the host is running).
Testing:
- Chassis On, Host On
Jul 30 14:40:37 rainxxx phosphor-host-state-manager[696]: Check if host is running
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Host is running!
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Initial Host State will be Running
- Chassis Off, Host Off
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Check if host is running
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Chassis power not on, exit
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Initial Host State will be Off
- Chassis On, Host Off
Jul 30 14:57:11 rainxxx phosphor-host-state-manager[1193]: Check if host is running
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Host is not running!
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Initial Host State will be Off
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I938902f526fba2f857be4b21b01149f8250b972d
|
| H A D | host_check.cpp | 0d1c3f1f9329c853677f0581287afef83eeea0f0 Tue Jul 27 15:21:01 CDT 2021 Andrew Geissler <geissonator@yahoo.com> host-check: discover host state within state manager
Currently the phosphor-host-state-manager is started before the logic
has run to detect if the host is already running. This results in
phosphor-host-state-manager temporarily reporting that the host is not
running, even if it actually is. This can cause confusion for clients
monitoring this property.
The solution is to move the logic which discovers if the host is running
into phosphor-host-state-manager. Having the logic to do this in a
separate application was a nice separation of concerns but when the
requirement is a co-req, best to just combine them.
This change results in the phosphor-host-state-manager service starting
later in the boot to BMC Ready but testing has shown no impacts to
overall time to reach BMC Ready or impacts to other services.
As a part of this change, the phosphor-reset-sensor-states service was
moved out of the obmc-host-reset target to ensure it and the
phosphor-host-state-manager service have the correct dependency between
them. The phosphor-host-state-manager service now ensures it runs after
the pldm and ipmi services if they are being started (they are
utilized to check if the host is running).
Testing:
- Chassis On, Host On
Jul 30 14:40:37 rainxxx phosphor-host-state-manager[696]: Check if host is running
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Host is running!
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Initial Host State will be Running
- Chassis Off, Host Off
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Check if host is running
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Chassis power not on, exit
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Initial Host State will be Off
- Chassis On, Host Off
Jul 30 14:57:11 rainxxx phosphor-host-state-manager[1193]: Check if host is running
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Host is not running!
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Initial Host State will be Off
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I938902f526fba2f857be4b21b01149f8250b972d
|
| H A D | meson.build | diff 0d1c3f1f9329c853677f0581287afef83eeea0f0 Tue Jul 27 15:21:01 CDT 2021 Andrew Geissler <geissonator@yahoo.com> host-check: discover host state within state manager
Currently the phosphor-host-state-manager is started before the logic
has run to detect if the host is already running. This results in
phosphor-host-state-manager temporarily reporting that the host is not
running, even if it actually is. This can cause confusion for clients
monitoring this property.
The solution is to move the logic which discovers if the host is running
into phosphor-host-state-manager. Having the logic to do this in a
separate application was a nice separation of concerns but when the
requirement is a co-req, best to just combine them.
This change results in the phosphor-host-state-manager service starting
later in the boot to BMC Ready but testing has shown no impacts to
overall time to reach BMC Ready or impacts to other services.
As a part of this change, the phosphor-reset-sensor-states service was
moved out of the obmc-host-reset target to ensure it and the
phosphor-host-state-manager service have the correct dependency between
them. The phosphor-host-state-manager service now ensures it runs after
the pldm and ipmi services if they are being started (they are
utilized to check if the host is running).
Testing:
- Chassis On, Host On
Jul 30 14:40:37 rainxxx phosphor-host-state-manager[696]: Check if host is running
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Host is running!
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Initial Host State will be Running
- Chassis Off, Host Off
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Check if host is running
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Chassis power not on, exit
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Initial Host State will be Off
- Chassis On, Host Off
Jul 30 14:57:11 rainxxx phosphor-host-state-manager[1193]: Check if host is running
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Host is not running!
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Initial Host State will be Off
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I938902f526fba2f857be4b21b01149f8250b972d
|
| H A D | host_state_manager.cpp | diff 0d1c3f1f9329c853677f0581287afef83eeea0f0 Tue Jul 27 15:21:01 CDT 2021 Andrew Geissler <geissonator@yahoo.com> host-check: discover host state within state manager
Currently the phosphor-host-state-manager is started before the logic
has run to detect if the host is already running. This results in
phosphor-host-state-manager temporarily reporting that the host is not
running, even if it actually is. This can cause confusion for clients
monitoring this property.
The solution is to move the logic which discovers if the host is running
into phosphor-host-state-manager. Having the logic to do this in a
separate application was a nice separation of concerns but when the
requirement is a co-req, best to just combine them.
This change results in the phosphor-host-state-manager service starting
later in the boot to BMC Ready but testing has shown no impacts to
overall time to reach BMC Ready or impacts to other services.
As a part of this change, the phosphor-reset-sensor-states service was
moved out of the obmc-host-reset target to ensure it and the
phosphor-host-state-manager service have the correct dependency between
them. The phosphor-host-state-manager service now ensures it runs after
the pldm and ipmi services if they are being started (they are
utilized to check if the host is running).
Testing:
- Chassis On, Host On
Jul 30 14:40:37 rainxxx phosphor-host-state-manager[696]: Check if host is running
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Host is running!
Jul 30 14:40:39 rainxxx phosphor-host-state-manager[696]: Initial Host State will be Running
- Chassis Off, Host Off
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Check if host is running
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Chassis power not on, exit
Jul 30 14:55:17 rainxxx phosphor-host-state-manager[710]: Initial Host State will be Off
- Chassis On, Host Off
Jul 30 14:57:11 rainxxx phosphor-host-state-manager[1193]: Check if host is running
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Host is not running!
Jul 30 14:57:18 rainxxx phosphor-host-state-manager[1193]: Initial Host State will be Off
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I938902f526fba2f857be4b21b01149f8250b972d
|
| /openbmc/openbmc/meta-phosphor/recipes-phosphor/state/ |
| H A D | phosphor-state-manager-systemd-links.inc | diff 9b5ed4cc2fdcc2ad4ae320d7fe9206f9d1e153b9 Tue Jul 27 15:28:58 CDT 2021 Andrew Geissler <geissonator@yahoo.com> host-check: check host state on startup of host manager
See this commit for more info on function and testing:
https://github.com/openbmc/phosphor-state-manager/commit/0d1c3f1f9329c853677f0581287afef83eeea0f0
phosphor-state-manager: srcrev bump 65bfcf5792..0d1c3f1f93
Andrew Geissler (1):
host-check: discover host state within state manager
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I04129b1838118efceb1d073539d01d6e1af99eec
|
| H A D | phosphor-state-manager_git.bb | diff 9b5ed4cc2fdcc2ad4ae320d7fe9206f9d1e153b9 Tue Jul 27 15:28:58 CDT 2021 Andrew Geissler <geissonator@yahoo.com> host-check: check host state on startup of host manager
See this commit for more info on function and testing:
https://github.com/openbmc/phosphor-state-manager/commit/0d1c3f1f9329c853677f0581287afef83eeea0f0
phosphor-state-manager: srcrev bump 65bfcf5792..0d1c3f1f93
Andrew Geissler (1):
host-check: discover host state within state manager
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I04129b1838118efceb1d073539d01d6e1af99eec
|