Searched hist:"0 b9e7b741f2bf8103b15bb14d5b4a6f5ee91c59a" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/drivers/scsi/ |
H A D | hpsa.c | diff 0b9e7b741f2bf8103b15bb14d5b4a6f5ee91c59a Thu Jun 26 08:44:52 CDT 2014 Arnd Bergmann <arnd@arndb.de> hpsa: fix non-x86 builds
commit 28e134464734 "[SCSI] hpsa: enable unit attention reporting" turns on unit attention notifications, but got the change wrong for all architectures other than x86, which now store an uninitialized value into the device register.
Gcc helpfully warns about this:
../drivers/scsi/hpsa.c: In function 'hpsa_set_driver_support_bits': ../drivers/scsi/hpsa.c:6373:17: warning: 'driver_support' is used uninitialized in this function [-Wuninitialized] driver_support |= ENABLE_UNIT_ATTN; ^
This moves the #ifdef so only the prefetch-enable is conditional on x86, not also reading the initial register contents.
Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 28e134464734 "[SCSI] hpsa: enable unit attention reporting" Cc: stable@vger.kernel.org # v3.14+ Acked-by: Stephen M. Cameron <scameron@beardog.cce.hp.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
|